[Bug 25236] TpBaseClient - initially, Client and Observer support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=25236

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
            Summary|TpBaseClient - an abstract  |TpBaseClient - initially,
                   |class to implement clients  |Client and Observer support
           Severity|normal                      |enhancement
           Priority|medium                      |high

--- Comment #36 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-04-28 08:38:41 PDT ---
(In reply to comment #34)
> > >   61  * Signature of the implementation of the ObserveChannels method.
> > >   62  * This function MUST call tp_observe_channels_context_accept,
> > >   63  * tp_observe_channels_context_delay or tp_observe_channels_context_fail.
> > 
> > This isn't an RFC (or telepathy-spec, which pretends to be one) so I'd be
> > inclined to not capitalize MUST. How about this?
> > 
> >  * Signature of the implementation of the ObserveChannels method.
> >  *
> >  * This function must call either tp_observe_channels_context_accept,
> >  * tp_observe_channels_context_delay or tp_observe_channels_context_fail
> >  * on @context before it returns.
> 
> changed.

I don't see this in the branch, did you forget to push it?

> > > +      DEBUG ("Failed to register bus name %s\n", string->str);
> > 
> > Remove \n
> 
> done.

I don't see this either?

I'll clone this bug for TpSimpleObserver, and for Handler and Approver support.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.