[Bug 25236] TpBaseClient - an abstract class to implement clients

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=25236

--- Comment #35 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-04-28 06:53:43 PDT ---
(In reply to comment #33)
> The regression test contains some dead code, but nothing serious.
> 
> (in the test)
> > +  test->dbus = test_dbus_daemon_dup_or_die ();
> > +  g_assert (test->dbus != NULL);
> 
> The assert here is pointless - the "or_die" suffix means "assert on failure".

removed.

> > +          "dbus-connection", ((TpProxy *) test->dbus)->dbus_connection,
> 
> Unnecessary - TpProxy gets this from the dbus-daemon if necessary.

removed.

> > +  if (test->error != NULL)
> > +    {
> > +      g_error_free (test->error);
> > +      test->error = NULL;
> > +    }
> 
> g_clear_error?

I always forget about this function. Fixed.

> > +  if (test->interfaces != NULL)
> > +    {
> > +      g_strfreev (test->interfaces);
> > +      test->interfaces = NULL;
> > +    }
> 
> g_strfreev is NULL-safe, just do this unconditionally.

done.

> (in simple-client.[ch])
> > + * Copyright (C) 2007-2008 Collabora Ltd. <http://www.collabora.co.uk/>
> 
> 2007-2010 (and wjt will be happy if you use © rather than (C) in new files :-)

done.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.