[Bug 27135] review TplConfIface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27135

--- Comment #10 from Will Thompson <will.thompson at collabora.co.uk> 2010-04-30 06:54:13 PDT ---
(In reply to comment #9)
> In 88932c31afa436ae28c10327df1d229898d0687b:
> 
> You convert a GSList to a GList, which seems redundant. Do you ever go
> backwards through the list? Why not leave it as a GSList?
> 
> Also, iterating and using a g_list_append() makes your conversion function
> O(n^2). Use g_list_prepend() and reverse the list afterwards.

Or, use a GQueue, a much-underused data structure which I think makes GList
nicer to use!

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.