[Bug 27865] Port more channel implementations to GabbleBaseChannel

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27865

Will Thompson <will.thompson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review-, minor changes      |

--- Comment #2 from Will Thompson <will.thompson at collabora.co.uk> 2010-04-30 13:05:02 PDT ---
(In reply to comment #1)
> > +  presence = gabble_presence_cache_get (self->parent.conn->presence_cache,
> > +      self->parent.target);
> 
> We generally avoid relying on the @parent member of instance structs like this,
> since it breaks if you change the inheritance hierarchy to include an extra
> intermediate class, which is meant to be something that's always safe in OO.

Normally I would kick up a fuss because I think that this is boilerplate for a
pretty much theoretical gain. However, I did just add an extra intermediate
class, and was inconsistent about which style I used in this branch. So...
patch pushed.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.