[Bug 13349] Review mail notification spec

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=13349





--- Comment #23 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk>  2010-02-23 10:49:45 PST ---
(In reply to comment #20)
> I've fixed various typos and made clarifications and editorial changes in
> <http://git.collabora.co.uk/?p=user/smcv/telepathy-spec-smcv.git;a=shortlog;h=refs/heads/mail-notification-editorial>
> - Nicolas, please review these, and merge them into nicolas/mail-notification
> if you approve?

I've merge you branch and apply some fixes, see comments below ...

> 
> Things I still don't like, after that branch is merged:
> 
> Mail_Type distinguishes between "is a mail" and "is a thread". A thread isn't a
> type of mail :-P so I think this should be called Mail_Notification_Type (both
> a Mail and a Thread could be said to be types of mail notification). Perhaps
> Mail should be renamed to Mail_Notification, too?

Mail_Type distinguish between "is a mail" and "is most recent mail of a
thread". In the second case you have the mail information plus some more
information about the thread (aka a context). The side effect is that you don't
need to show the older mails withing the same thread since this would be
outdated and redundant information.

Also Mail (if renamed Mail_Notification) is not an abstraction to all
notifications that comes from the API. This naming imply a totally different
design. It would feel like the API would provide a Mail_Notification for
anything that happen.

> 
> Subscribe is documented to raise Disconnected and NetworkError (which I can
> understand), but also NotAvailable and PermissionDenied (which I can't). When
> would it raise these errors?

Turns out that errors where still random copy paste, fixed.

> 
> sent-timestamp, received-timestamp are meaningless for threads, as currently
> written; please either forbid them for threads, or re-define them as "the most
> recent" or "the oldest" (your choice).

Defined has the most recent (in link with the fact that thread == most recent
mail of a thread).

> 
> MailsReceived allows 'id' to be non-unique, which directly contradicts the
> definition of 'id'. Possible resolutions:
> 

Fixed, 'id' must be unique otherwise unset.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.