[Bug 26712] Telepathy-logger should support storing and retrieving favorite Telepathy contacts

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=26712





--- Comment #4 from Danielle Madeley <danielle.madeley at collabora.co.uk>  2010-02-24 22:07:58 PST ---
+      link->action (self, link->user_data);
+      g_slice_free (TplActionLink, link);

Minor: use link_free() ?

I am happy with the TplActionChain changes though. Those can be merged
immediately.

+    <signal name="FavouriteContactsReady"
+      tp:name-for-bindings="Favourite_Contacts_Ready">
+      <tp:docstring>
+        The <tp:dbus-ref
+       
namespace="org.freedesktop.Telepathy.Logger.DRAFT">FavouriteContacts</t
+      </tp:docstring>
+    </signal>

You can remove this now, right?

+      g_hash_table_insert (contacts, g_strdup (contact_id), "placeholder");

0x1 is more traditional. or GINT_TO_POINTER (TRUE).

+  contact_ids = g_malloc0 (sizeof (gchar*) * (g_hash_table_size
(contacts)+1));

g_new0 -> less braces :)

+      contact_ids[i] = g_strdup ((const gchar*) l->data);

+  g_strfreev (contact_ids);

Save yourself the strdup here and just g_free (contact_ids) when you're done?

+  g_hash_table_foreach (priv->accounts_contacts_map,
+      (GHFunc) append_favourite_contacts_account_and_contacts, packed);

Would a GHashTableIter be more useful here?

+#define TPL_DATA_DIR "TpLogger"

Better to export $(datadir) from Makefile.am

+  FavouriteContactClosure *closure = (FavouriteContactClosure*) user_data;

Isn't this cast redundant?

+  if (action_chain != NULL)
+        tpl_actionchain_continue (action_chain);

Too much indenting.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.