[Bug 26712] Telepathy-logger should support storing and retrieving favorite Telepathy contacts

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=26712





--- Comment #5 from Travis Reitter <travis.reitter at collabora.co.uk>  2010-02-25 10:12:34 PST ---
> +    <signal name="FavouriteContactsReady"
> +      tp:name-for-bindings="Favourite_Contacts_Ready">
> +      <tp:docstring>
> +        The <tp:dbus-ref
> +       
> namespace="org.freedesktop.Telepathy.Logger.DRAFT">FavouriteContacts</t
> +      </tp:docstring>
> +    </signal>
> 
> You can remove this now, right?

I think this shows how annoying the distinction between FavouriteContactsReady
and FavouriteContactsIsReady would have been - I removed the latter and forgot
about the former.

> +  contact_ids = g_malloc0 (sizeof (gchar*) * (g_hash_table_size
> (contacts)+1));
> 
> g_new0 -> less braces :)

Er, right. I mixed it up in my mind with some other function that doesn't let
you specify the count.

> +  g_hash_table_foreach (priv->accounts_contacts_map,
> +      (GHFunc) append_favourite_contacts_account_and_contacts, packed);
> 
> Would a GHashTableIter be more useful here?

I find a foreach more compact and easier to read.

> +#define TPL_DATA_DIR "TpLogger"
> 
> Better to export $(datadir) from Makefile.am

Isn't that always some absolute path that the user doesn't usually have write
access to (eg, default /usr/local/share)?

Do you mean something like $(PACKAGE_NAME) (so we end up with
$(XDG_DATA_DIR)/$(PACKAGE_NAME))? I've made that change locally. "TpLogger" is
somewhat historical, since the logger used to use that for something else, but
apparently doesn't any longer.


I've also made the other fixes you've suggested (and trivial style fixes to
satisfy "make check"). Please review the last two commits on branch
favorites-try3. It's re-based upon the latest mainline.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.