[Bug 26583] Allow channels to be dispatched before a connection is established

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=26583


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|patch                       |
  Status Whiteboard|                            |reviewed, minor changes
                   |                            |please




--- Comment #7 from Simon McVittie <simon.mcvittie at collabora.co.uk>  2010-02-26 05:09:09 PST ---
+    if (!priv->dispatching_started)
     _mcd_dispatcher_add_connection (priv->dispatcher, connection);

Indentation, please.

+    e = q.expect('dbus-signal', signal='StatusChanged')
+
+    # Connection should be in "Connecting" status for this test.
+    assert e.args == [cs.CONN_STATUS_CONNECTING,
cs.CONN_STATUS_REASON_REQUESTED]

This seems suspicious: this signal was emitted by the SimulatedConnection,
which is part of your test code, so you shouldn't have to expect() it. You can
expect() a call to Connect() instead?

The code changes look good, though.


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.