[Bug 26583] Allow channels to be dispatched before a connection is established

[bugzilla-daemon at freedesktop.org]

http://bugs.freedesktop.org/show_bug.cgi?id=26583


Eitan Isaacson <eitan.isaacson at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
           Keywords|                            |patch




--- Comment #8 from Eitan Isaacson <eitan.isaacson at collabora.co.uk>  2010-02-26 08:42:03 PST ---
(In reply to comment #7)
> +    if (!priv->dispatching_started)
>      _mcd_dispatcher_add_connection (priv->dispatcher, connection);
> 
> Indentation, please.

That file is very confusing. Right above that statement is a similar one with a
tab indentation. Anyway, I fixed it to what I believe it should be in that
file.

> 
> +    e = q.expect('dbus-signal', signal='StatusChanged')
> +
> +    # Connection should be in "Connecting" status for this test.
> +    assert e.args == [cs.CONN_STATUS_CONNECTING,
> cs.CONN_STATUS_REASON_REQUESTED]
> 
> This seems suspicious: this signal was emitted by the SimulatedConnection,
> which is part of your test code, so you shouldn't have to expect() it. You can
> expect() a call to Connect() instead?

Yeah, that's stupid. Fixed.

> 
> The code changes look good, though.
> 


-- 
Configure bugmail: http://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the assignee for the bug.