[Bug 23151] Rethink API for named chatrooms

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=23151

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|NEW                         |ASSIGNED
  Status Whiteboard|                            |review+ as draft, minor
                   |                            |changes
           Keywords|                            |patch
         AssignedTo|telepathy-bugs at lists.freede |jonny.lamb at collabora.co.uk
                   |sktop.org                   |

--- Comment #13 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-07-29 04:42:35 PDT ---
I think this is basically good to merge as a draft, with or without the changes
below.

> RoomID — s, Read only
>
> The human-readable identifier of a chat room. Note that this property (and
> perhaps also Server) should be sufficient in a channel request to join the room.

"Note that if non-empty, this property..." might be clearer?

> Subject — (ssx)

This seems like a namespace grab, could we make it a type called Room_Subject?
That'd become TP_STRUCT_TYPE_ROOM_SUBJECT in telepathy-glib or Tp::RoomSubject
in telepathy-qt4. The property can stay as Subject though.

It might be worth saying explicitly that the Subject should be ("", "", 0) in
protocols that don't have subjects (MSN?).

Cross-references:

- Subject should have a tp:rationale saying it replaces the subject,
subject-contact and subject-timestamp Telepathy.Properties of Text channels

- Those Telepathy.Properties should cross-reference to Chan.I.Room.Subject

- Chan.T.RoomList.GotRooms should gain a "room-id" key in its a{sv}, whose
value is defined to be the Chan.I.Room.RoomID, with a link

- Either Chan.T.RoomList.GotRooms should gain a "server" key for completeness,
or the text should say that clients may assume that the Chan.I.Room.Server is
the same as the Chan.T.RoomList.Server

- Chan.T.RoomList.GotRooms' "subject" a{sv} key should link to
Chan.I.Room.Subject

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.