[Bug 23151] Rethink API for named chatrooms

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=23151

--- Comment #14 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2010-07-29 06:09:45 PDT ---
(In reply to comment #13)
> "Note that if non-empty, this property..." might be clearer?

Done.

> This seems like a namespace grab, could we make it a type called Room_Subject?
> That'd become TP_STRUCT_TYPE_ROOM_SUBJECT in telepathy-glib or Tp::RoomSubject
> in telepathy-qt4. The property can stay as Subject though.

Done.

> It might be worth saying explicitly that the Subject should be ("", "", 0) in
> protocols that don't have subjects (MSN?).

Done.

> - Subject should have a tp:rationale saying it replaces the subject,
> subject-contact and subject-timestamp Telepathy.Properties of Text channels

Done.

> - Those Telepathy.Properties should cross-reference to Chan.I.Room.Subject

Done.

> - Chan.T.RoomList.GotRooms should gain a "room-id" key in its a{sv}, whose
> value is defined to be the Chan.I.Room.RoomID, with a link

Done.

> - Either Chan.T.RoomList.GotRooms should gain a "server" key for completeness,
> or the text should say that clients may assume that the Chan.I.Room.Server is
> the same as the Chan.T.RoomList.Server

I added the server key.

> - Chan.T.RoomList.GotRooms' "subject" a{sv} key should link to
> Chan.I.Room.Subject

Done.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.