[Bug 27874] TpBaseClient Approver support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27874

--- Comment #8 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-05-07 02:36:46 PDT ---
Replying here as that's the right bug.

> > + * This function must call either tp_add_dispatch_operation_context_accept(),
> > + * tp_add_dispatch_operation_context_delay() or
> > + * tp_add_dispatch_operation_context_fail() on @context before it returns.
> 
> I think it's also worth putting in a reference to the HandleWith and Claim
> wrappers.

Done.

> > +      if (g_error_matches (error, TP_DBUS_ERRORS, TP_DBUS_ERROR_OBJECT_REMOVED))
> > +        {
> > +          /* There is no point calling the AddDispatchOperation
> > +           * implementation; just terminate the D-Bus call right away */
> > +          tp_add_dispatch_operation_context_accept (ctx);
> > +        }
> 
> This isn't meant to happen - ChannelLost and Finished are meant to be delayed
> until all approvers have returned from AddDispatchOperation (per the spec), and
> we're an approver that hasn't returned. So, I don't think it's worth a special
> case.

Cool. Removed.

> >     test-base-client: test invalidating one channel while calling AddDispatchOperation
> 
> This looks as if it contains a secret bugfix? :-)

Yeah, but I probably squash the fix while rebasing. :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.