[Bug 27874] TpBaseClient Approver support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27874

--- Comment #9 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-05-07 02:50:27 PDT ---
(In reply to comment #9)
> As with the Observer context, it would be good to use the shared
> TpAccountManager, TpAccount, TpConnection chain if possible.
> 
> It might be good to have the CDO and the Approver context receive an account
> and a connection as optional construct-time properties, which would change the
> processing to something like:
> 
> set_property:
>     remember the immutable properties
>     *don't* make Account etc. proxies
> 
> constructed:
>     if no Account, Connection, etc. were supplied at construct time,
>     look in the immutable properties and try to set them
> 
> Alternatively, the CDO and context could take the TpAccountManager as a
> construct-time property, and start the chain there.

Why not just do the same trick in the CDO using
_tp_dbus_daemon_is_the_shared_one and create the AM accordingly? That way we
wouldn't have to add new API.

Note that this doesn't solve the "issue" of having different TpChannel objects
in the context and in CDO.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.