[Bug 27833] TpChannelDispatchOperation high-level methods and CORE feature

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27833

--- Comment #12 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-07 03:48:50 PDT ---
(In reply to comment #11)
> Hum, in that case should I recreate the priv->connetion as well? Didn't we
> already lost if the initial properties were actually wrong?

My complaint was that you emit notify::connection before checking whether to
actually change the Connection object - just move the notify emission down a
bit, I think. Yes, we should disregard the case of having incorrect initial
properties.

> > The CDO should be invalidated if its D-Bus properties aren't sane.
> 
> Done.
> Does that include if the properties are not the same as the ones when received
> in tp_channel_dispatch_operation_new?

I think we should trust the properties from tp_channel_dispatch_operation_new,
and assume they're right; if immutable properties were provided up-front,
everything except Channels in the GetAll result can be ignored.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.