[Bug 27874] TpBaseClient Approver support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27874

--- Comment #11 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-07 05:04:30 PDT ---
Trivia seen when reading through the combined diff (you can consider the fixes
for these to have been pre-reviewed):

> +++ b/telepathy-glib/add-dispatch-operation-context-internal.h

Copyright date should be 2010 like the others, or 2009-2010 if it's derived
from code from 2009

> +  void (*chain_up) (GObject *) =
> +    ((GObjectClass *) \
> +      tp_add_dispatch_operation_context_parent_class)->constructed;

You don't need that backslash, line-joining is generally only relevant in macro
definitions

> + * Implementation can then use tp_channel_dispatch_operation_handle_with_async()
> + * or tp_channel_dispatch_operation_claim_async() to approve or disapprove the
> + * channels.

"The implementation can then use
tp_channel_dispatch_operation_handle_with_async() to approve handling of the
channels, or tp_channel_dispatch_operation_claim_async() to take responsibility
for handling or closing them", perhaps?

> and may only be called on objects that implement
> + * @add_dispatch_operation.

"and may only be called on objects whose class has called
tp_base_client_implement_add_dispatch_operation()" perhaps?

> +  if (cls->priv->add_dispatch_operation_impl == NULL)
> +    {
> +      DEBUG ("class %s does not implement AddDispatchOperation",
> +          G_OBJECT_TYPE_NAME (self));

CRITICAL()? This isn't meant to be reachable, AFAICS.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.