[Bug 27833] TpChannelDispatchOperation high-level methods and CORE feature

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27833

--- Comment #16 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-05-07 05:11:42 PDT ---
(In reply to comment #13)
> Other minor things, apart from the whole "I think the child objects should be
> pushable in at construct-time" issue:

At this involves adding new API and we'll have to support the current one as
well, would it be ok if I solve that in another branch based on the approver
one? That would make testing easier and will avoid potential conflicts.

> > + * If a channel closes, the #TpChannelDispatchOperation::channel-lost signal
> > + * is emitted. If all channels
> >   * close, there is nothing more to dispatch, so the invalidated signal will be
> >   * emitted with the domain %TP_DBUS_ERRORS and the error code
> >   * %TP_DBUS_ERROR_OBJECT_REMOVED.
> 
> This would be better as "the #TpProxy::invalidated signal" (my fault, but it
> seems better to fix it in this branch than to have a trivia branch).

Fixed.

> > +  g_object_notify ((GObject *) self, "channel-dispatch-operation-properties");
> 
> Perhaps "cdo-properties"?

Renamed.

> > + * tp_channel_dispatch_operation_borrow_immutable_properties:
> 
> These borrow() functions should probably all be (skip) - they're "C bindings"
> for a GObject property.
> 
> The result of tp_channel_dispatch_operation_borrow_immutable_properties should
> also be (element-type utf8 GObject.Value).

done.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.