[Bug 26249] get GObject-Introspection bindings stable and somewhat complete

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon May 24 12:22:30 CEST 2010


https://bugs.freedesktop.org/show_bug.cgi?id=26249

--- Comment #30 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-24 03:22:29 PDT ---
(In reply to comment #29)
> Created an attachment (id=35385)
 --> (https://bugs.freedesktop.org/attachment.cgi?id=35385)
> Adds garray parameter annotations, and skips tp_g_value_slice_* functions

Now that GObject-Introspection 0.6.11 is available to be depended on, I've
merged this; it'll be released in tp-glib 0.11.6.

For future reference, here's my review of that patch:

* technically correct
* several lines had trailing whitespace, which I've removed (git can be
  configured to complain about "whitespace errors", which is recommended)
* in future, please err on the side of having more, smaller patches: the
  (skip) bits could have been merged already if you hadn't committed them in
  the same patch as the GArray bits

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.



More information about the telepathy-bugs mailing list