[Bug 27872] TpBaseClient Handler support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27872

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/ |http://git.collabora.co.uk/
                   |?p=user/cassidy/telepathy-g |?p=user/smcv/telepathy-glib
                   |lib;a=shortlog;h=refs/heads |-smcv.git;a=shortlog;h=refs
                   |/base-handler-27872         |/heads/handler
           Keywords|                            |patch

--- Comment #6 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-24 03:38:58 PDT ---
> +  tp_dbus_daemon_unregister_object (tp_base_connection_get_dbus_daemon (
> +        test->base_connection), test->text_chan_service);
> +  /*
> +  g_object_unref (test->text_chan_service);
> +  test->text_chan_service = NULL;
> +  */

Aha! Forcibly taking a channel off D-Bus won't trigger client-side invalidation
(how could it? the client doesn't know it's disappeared!). You need to make it
emit Closed somehow, before it's removed from D-Bus. (After it's removed,
emitting TpSvcChannel::closed doesn't emit Closed any more, for obvious
reasons.)

For hysterical raisins, causing most channel implementations to be disposed has
the side-effect of emitting Closed, but that's not really right.

I've fixed that, and the test now passes:

http://git.collabora.co.uk/?p=user/smcv/telepathy-glib-smcv.git;a=shortlog;h=refs/heads/handler

With that change I reckon it's reviewable, so I'll review the rest of your
branch now.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.