[Bug 27872] TpBaseClient Handler support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27872

--- Comment #9 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-05-24 08:04:45 PDT ---
(In reply to comment #6)
> I've fixed that, and the test now passes:

Great. I merged your branch to mine but the test now crashes:

** CRITICAL **: dbus_g_connection_unregister_g_object: assertion `registrations
!= NULL' failed

#4  0x000000000040c266 in channel_get_interfaces (iface=0x20b5c10,
context=0x20b5c00) at textchan-null.c:489


(In reply to comment #8)
> +++ b/tests/dbus/base-client.c
> > +#include <telepathy-glib/handle-channels-context-internal.h>
> 
> Why? If possible I'd prefer it if regression tests didn't use internal API.

We use it to easily access to the ctx semi-private attributes (conn, account,
channels, etc).
Note that we do that for the Observer and Approver as well.

> > +  param_spec = g_param_spec_uint64 ("user-action-time",
> 
> This (and friends) should probably be an int64 that happens to be positive,
> even though we get a uint64 from D-Bus (which was a mistake in tp-spec).
> 
> It'd be good to document it in terms of the stuff you recently merged to
> tp-spec, too (with the 0 and G_MAXINT64 special cases).

done.

> Non-blocking trivia
> ===================
> 
> > +      g_warning ("Disposing a context in the %s state",
> 
> Could be WARNING().

done.

> > +  void (*chain_up) (GObject *) =
> > +    ((GObjectClass *) \
> > +      tp_handle_channels_context_parent_class)->constructed;
> 
> Unnecessary backslash.

removed.

> > +  GList *l;
> 
> In future I'd prefer it if you'd avoid lower-case L as a variable name - it
> looks a lot like 1.

That's used in a lot of place in telepathy.

> > +#include "telepathy-glib/handle-channels-context-internal.h"
> > +#include "telepathy-glib/handle-channels-context.h"
> 
> Please put the public header first; the point of doing that is to verify that
> the public header is self-contained.

done.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.