[Bug 27872] TpBaseClient Handler support

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=27872

--- Comment #10 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-05-24 09:08:44 PDT ---
Your changes look good.

(In reply to comment #9)
> (In reply to comment #6)
> > I've fixed that, and the test now passes:
> 
> Great. I merged your branch to mine but the test now crashes:
> 
> ** CRITICAL **: dbus_g_connection_unregister_g_object: assertion `registrations
> != NULL' failed
> 
> #4  0x000000000040c266 in channel_get_interfaces (iface=0x20b5c10,
> context=0x20b5c00) at textchan-null.c:489

I don't know why it'd be doing that, but will investigate a bit.

> (In reply to comment #8)
> > +++ b/tests/dbus/base-client.c
> > > +#include <telepathy-glib/handle-channels-context-internal.h>
> > 
> > Why? If possible I'd prefer it if regression tests didn't use internal API.
> 
> We use it to easily access to the ctx semi-private attributes (conn, account,
> channels, etc).
> Note that we do that for the Observer and Approver as well.

That's an acceptable use, but I'd prefer it commented.

> > > +  GList *l;
> > 
> > In future I'd prefer it if you'd avoid lower-case L as a variable name - it
> > looks a lot like 1.
> 
> That's used in a lot of place in telepathy.

Yeah, wjt overruled this too. Fair enough.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.