[Bug 28200] TpContactListManager (or perhaps TpBaseContactList)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28200

--- Comment #2 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-05-28 07:46:01 PDT ---
Review to f56db201f69bc10768fc365128025a21157acf04 (included):

+  _tp_dynamic_handle_repo_set_normalization_data ((TpHandleRepoIface *) obj,
+      NULL, NULL);
Maybe add a comment saying that's to call the GDestroyNotify on the existing
data?

there are 2 FIXME:
+      /* FIXME: borrowed reference */

+  self->priv->groups = g_hash_table_new_full (g_direct_hash, g_direct_equal,
+      NULL, g_object_unref);
+  self->priv->queued_requests = g_hash_table_new_full (g_direct_hash,
+      g_direct_equal, NULL, NULL);
+}

I heard than passing NULL as hash_func and key_equal_func but is more
optimized.


I'll continue the review on Monday.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.