[Bug 28200] TpContactListManager (or perhaps TpBaseContactList)

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28200

--- Comment #3 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2010-05-31 01:49:29 PDT ---
Didn't see anything obvioulsy wrong in the latest commits. The design and
implementation is pretty clear; nice work!
Did you already ported a CM to it?

2 small nipticks:

tp_contact_list_manager_groups_created
+              g_ptr_array_add (pa, (gchar *) tp_handle_inspect (
+                    self->priv->group_repo, handle));
+
+            }

Useless \n

+    /* string borrowed from priv->all_tags => itself */
I had to check what the "itself" actually meant (the self pointer or
something?) but it seemed obvious once I read the code. :)


I've been pleased to see that Géraldine and me are in this example :)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.