[Bug 31631] New: Serious issues with TpClientChannelFactoryInterface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=31631

           Summary: Serious issues with TpClientChannelFactoryInterface
           Product: Telepathy
           Version: unspecified
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: major
          Priority: medium
         Component: tp-glib
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: guillaume.desmottes at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


While starting to use TpClientChannelFactoryInterface in Empathy I found 2 big
issues with it.

A) tp_base_client_set_channel_factory() is broken. This is fixed in
http://git.collabora.co.uk/?p=user/cassidy/telepathy-glib;a=commitdiff;h=9deb3dcad3a60f43d6367296ae32f2b26c4103a6

B) The 'self' pointer passed to method implementation is wrong.
-    return iface->dup_channel_features (iface, channel);
+    return iface->dup_channel_features (self, channel);
solves it but it seems that something is wrong.

This cast is suspicious, self is supposed to already be a
TpClientChannelFactoryInterface; so why do we need to cast it?

 TpClientChannelFactoryInterface *iface = TP_CLIENT_CHANNEL_FACTORY_GET_IFACE (
      self);

And I'm wondering if the TP_CLIENT_CHANNEL_FACTORY macro really makes sense as
that's an iface and not an object?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.