[Bug 30810] Wocky leaks while running unit tests

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30810

--- Comment #1 from Will Thompson <will.thompson at collabora.co.uk> 2010-10-13 02:17:24 PDT ---
Looks good, apart from style! :)

+      if (!g_cancellable_is_cancelled (priv->cancellable))
+        {
+          g_cancellable_cancel (priv->cancellable);
+        }
+      g_object_unref (priv->cancellable);
+      priv->cancellable = NULL;

I think the if statement here should not use braces.

+  if (priv->conn)

This should check != NULL explicitly. There are loads of other cases of this in
this branch.

English pedantry in a commit message for future reference: in “Most call where
already implemented correctly”, you mean “were”.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.