[Bug 30810] Wocky leaks while running unit tests

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=30810

--- Comment #2 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2010-10-13 08:53:48 PDT ---
(In reply to comment #1)
> Looks good, apart from style! :)

Sorry for that, I'm stepping from project all the time and I often loose track
of right coding style.

> 
> +      if (!g_cancellable_is_cancelled (priv->cancellable))
> +        {
> +          g_cancellable_cancel (priv->cancellable);
> +        }
> +      g_object_unref (priv->cancellable);
> +      priv->cancellable = NULL;
> 
> I think the if statement here should not use braces.

Fixed.

> 
> +  if (priv->conn)
> 
> This should check != NULL explicitly. There are loads of other cases of this in
> this branch.

Ok, since it was simpler to search them all I've end up fixing 30 of them.

> 
> English pedantry in a commit message for future reference: in “Most call where
> already implemented correctly”, you mean “were”.

Fixed/Rebased


So I'll merge and push this branch soon.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.