[Bug 28413] Gabble DTMF

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=28413

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |sjoerd at luon.net

--- Comment #7 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2010-10-13 09:28:17 PDT ---
(In reply to comment #5)
> I've picked this up and brought it up to date with current telepathy-spec. See
> "URL" field for my branch.

I now also have a subset of that branch,
<http://git.collabora.co.uk/?p=user/smcv/telepathy-gabble-smcv.git;a=shortlog;h=refs/heads/dtmf-from-the-past>,
which doesn't implement MultipleTones. We could use that branch to get basic
DTMF support merged without deciding on MultipleTones' exact semantics.

That subset doesn't have a regression test, but I could backport the one from
smcv/dtmf (with the MultipleTones-related bits deleted) if required.

> • It might try to send DTMF before a stream is connected, which won't work

Still unresolved, but not very important for StartTone/StopTone - it becomes
more signficant when we implement InitialTones.

> • The timings in media-channel.c (stop StartTone tones after at most 10
> seconds; send MultipleTones with 200ms tones and 100ms gaps between them) are
> entirely arbitrary

Pekka seems to think 200ms and 100ms are entirely reasonable, so let's keep
them.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.