[Bug 32611] Implement Room interface

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=32611

Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review-, minor changes

--- Comment #3 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-01-03 06:25:54 PST ---
> +  g_object_get (self, "target-id", &tmp, NULL);

Moar newlines to group parameter pairs (or pair in this case) please, as per
/Style

> +  /* The target ID has already been checked so we don't care about the
> +   * return type of gabble_decode_jid, but it warns if it the result
> +   * is unused. */

g_assert (ok) then, so it's genuinely used and not just assigned to a useless
variable? Or, explicitly cast the return to (void), which iirc silences that
warning.

+    # Now a channel which already exists (any of the above) with
+    # RoomID set.
+    jid = 'booyakasha at conf.localhost'
+    call_async(q, conn.Requests, 'EnsureChannel', {
+            cs.CHANNEL_TYPE: cs.CHANNEL_TYPE_TEXT,
+            cs.TARGET_HANDLE_TYPE: cs.HT_ROOM,
+            cs.TARGET_ID: jid,
+            cs.ROOM_ROOM_ID: '',
+            })
+
+    e = q.expect('dbus-error', name=cs.INVALID_ARGUMENT,
method='EnsureChannel')

I'm not convinced this should fail: the empty RoomID isn't really part of the
identity of the channel, surely? We're requesting the same room as before, but
this time providing the information that its name is meaningless, which we
neglected to provide first time round.

That's all for /room.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.