[Bug 32611] Implement Room interface

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jan 3 15:29:43 CET 2011


--- Comment #4 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-01-03 06:29:43 PST ---
/moar-room mostly looks good too:

+  gabble_svc_channel_interface_room_emit_subject_changed (chan,
+      g_value_get_string (g_value_array_get_nth (priv->subject, 0)),
+      g_value_get_string (g_value_array_get_nth (priv->subject, 1)),
+      g_value_get_int64 (g_value_array_get_nth (priv->subject, 2)),
+      room_subject_flags);

Perhaps have a helper function for "emit SubjectChanged, assuming the property
has already been set to the new value"?

> +        check_room_props(chan, 'Testing', room + '/bob', 3, signal=s)

Please replace 3 with a constant (3 times)

> +    assertEquals(str(elem.children[0]), 'le lolz')

Please check that the first child is indeed <subject/>

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list