[Bug 32692] Support Protocol.Interface.Addressing in Gabble

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jan 3 15:45:43 CET 2011


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
  Status Whiteboard|                            |review-, minor changes
         AssignedTo|telepathy-bugs at lists.freede |eitan.isaacson at collabora.co
                   |sktop.org                   |.uk

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-01-03 06:45:42 PST ---
+  if (!valid_field_or_scheme (vcard_field, addressing_vcard_fields))
+    {
+      g_set_error (error, TP_ERRORS, TP_ERROR_NOT_IMPLEMENTED,
+          "'%s' vCard field is not supported by this protocol", vcard_field);
+    }

This seems speculatively general, for a protocol that only supports one vCard

It's also the wrong shape for protocols that support many vCard fields via
gatewaying: in such a protocol, the normalization will probably be different
for different fields.

I'd tend to do:

if (it's "xmpp")
    normalize it for XMPP

with an obvious place to put an "else if" clause for hypothetical other fields.

+  /* excuse the poor man's URI parsing, couldn't find a GLib helper */
+  gchar *scheme = g_uri_parse_scheme (uri);

Er, you found one? :-)

This does look good enough to not block undraft (Bug #32690), though.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list