[Bug 32691] Support addressing in TpBaseProtocol

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jan 3 15:40:27 CET 2011


Simon McVittie <simon.mcvittie at collabora.co.uk> changed:

           What    |Removed                     |Added
             Status|NEW                         |ASSIGNED
  Status Whiteboard|                            |review-, minor changes
         AssignedTo|telepathy-bugs at lists.freede |eitan.isaacson at collabora.co
                   |sktop.org                   |.uk

--- Comment #1 from Simon McVittie <simon.mcvittie at collabora.co.uk> 2011-01-03 06:40:26 PST ---
(This can't be merged until the undrafted spec has landed and been released.)

I'm not really sure that Addressing should be in the TpBaseProtocol vtable:
we're running out of slots, and Addressing doesn't seem particularly
fundamental. Maybe it should be a GInterface (see how TpBaseContactList does
its optional functionality, for instance). I could be persuaded either way.

> + * TpBaseProtocolGetAddressingDetailsFunc:

...Dup... rather than Get, really.

> + * Since: 0.13.11

No such version yet, so who can say what'll be in it? 0.13.UNRELEASED, please.

> TpBaseProtocolAddressingNormalizeVCardAddressFunc

I don't think the word Addressing adds value here.

>+ * TpBaseProtocolAddressingNormalizeUriFunc:

Likewise, and I'd also prefer the acronym capitalized:

> +      addressing_iface_init));

That trailing semicolon isn't needed, and causes an empty statement to appear,
which breaks some compilers.

> +  if (tp_strv_contains ((const gchar * const*) self->priv->interfaces,

const * (with a space)

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list