[Bug 32902] review Pidgin log store and dbus testsuite

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jan 20 22:47:37 CET 2011


Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
                URL|http://git.collabora.co.uk/ |
                   |?p=user/kalfa/telepathy-log |http://git.collabora.co.uk/
                   |ger.git;a=shortlog;h=refs/h |?p=user/nicolas/telepathy-l
                   |eads/pidgin_store_allinone  |ogger.git;a=shortlog;h=refs
                   |                            |/heads/pidgin-log-store
  Status Whiteboard|review+ (need rebasing      |review-
                   |though)                     |

--- Comment #8 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2011-01-20 13:47:36 PST ---
As the tree has changed significantly I've rebased/fixed everything. I was
mainly interested in the tests with real data. So far the new test won't pass
and doing this work showed me couple of things I don't like:

- Test should not output debugging by default
- Test should run with valgrind without leaks
- the dbus directoy is annoying since it's Makefile contains bunch of
duplicates, I suggest using a DBUS_TEST_EXETRUABLE variable instead
- Tests should always run through the public API (yes the _aynsc/_finish)
- We should probably post-fix test program with -test instead of prefixing them
- etc.


Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list