[Bug 32902] review Pidgin log store and dbus testsuite

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jan 21 23:23:11 CET 2011


Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> changed:

           What    |Removed                     |Added
  Status Whiteboard|review-                     |
           Keywords|                            |patch

--- Comment #9 from Nicolas Dufresne <nicolas.dufresne at collabora.co.uk> 2011-01-21 14:23:10 PST ---
(In reply to comment #8)
> As the tree has changed significantly I've rebased/fixed everything. I was
> mainly interested in the tests with real data. So far the new test won't pass
> and doing this work showed me couple of things I don't like:
> - Test should not output debugging by default
> - Test should run with valgrind without leaks
> - the dbus directoy is annoying since it's Makefile contains bunch of
> duplicates, I suggest using a DBUS_TEST_EXETRUABLE variable instead
> - Tests should always run through the public API (yes the _aynsc/_finish)
> - We should probably post-fix test program with -test instead of prefixing them
> - etc.

I updated the branch, skipped couple of listed items since they can be carried
later. I decided to keep the dbus folder since it's simplier.

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list