[Bug 33404] Move caps hash stuff to Wocky

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Mon Jan 24 14:30:42 CET 2011


--- Comment #3 from Will Thompson <will.thompson at collabora.co.uk> 2011-01-24 05:30:42 PST ---
It's actually not entirely clear to me that there's any value in
WockyDiscoIdentity having accessors for all its fields, rather than the caller
just using identity->type and friends.

 197   if (!source)
 198     return NULL;

g_return_val_if_fail (source != NULL, NULL);

 226   if (!arr)
 227     return;

if (arr == NULL)

- * caps-hash.c - Computing verification string hash (XEP-0115 v1.5)
- * Copyright (C) 2008 Collabora Ltd.
+ * wocky-caps-hash.c - Computing verification string hash (XEP-0115 v1.5)
+ * Copyright (C) 2008-2010 Collabora Ltd.

It's 2011.

On top of _compute_from_node(), shouldn't there be a function that computes a
hash from a list of features, identities, and data forms? Otherwise
Gabble/Salut will need to build up a WockyNode whenever they need to hash their
caps… oh! they have to do this anyway, I suppose maybe?

Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.

More information about the telepathy-bugs mailing list