[Bug 33404] Move caps hash stuff to Wocky

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=33404

--- Comment #4 from Will Thompson <will.thompson at collabora.co.uk> 2011-01-24 06:03:25 PST ---
+#ifndef __WOCKY_PLUGINS_DISCO_IDENTITY_H__

o rly

Technically we should not be using __-prefixed guards. It should really be
WOCKY_PLUGINS_DISCO_IDENTITY_H. But this is pedantry.


 static gint
 identity_cmp (gconstpointer a, gconstpointer b)

I think the guts of this function should be wocky_disco_identity_cmp
(WockyDiscoIdentity *a, WockyDiscoIdentity *b). But obviously you'll still need
the wrapper for GPtrArray silliness.


  * Computes verification string hash according to XEP-0115 v1.5

Hashes plural.

+ *
+ * Wocky does not do anything with dataforms (XEP-0128) included in
+ * capabilities.  However, it needs to parse them in order to compute the hash
+ * according to XEP-0115.

I don't think this is a particularly useful comment, honestly. The “does not do
anything with” bit is liable to become wrong. I imagine we'll ultimately have
something like:

  WockyCapabilities *wocky_capabilities_from_node (WockyNode *);
  /* accessors for identities, features, and forms */
  gchar *wocky_capabilities_calculate_hash (WockyCapabilities *,
GChecksumType);

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.