[Bug 32986] Add a python example showing how to ensure a channel

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jan 27 17:05:43 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=32986

Tomeu Vizoso <tomeu at tomeuvizoso.net> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|                            |review+

--- Comment #3 from Tomeu Vizoso <tomeu at tomeuvizoso.net> 2011-01-27 08:05:42 PST ---
> +def create_request(action, contact_id):

Was surprised to see that it didn't returned some kind of Request object, I
would rename it to create_request_dict() or something similar.

> +    # FIXME: for some reason TelepathyGLib.USER_ACTION_TIME_CURRENT_TIME is

I would add a link to the bug to increase the chances that someone will remove
the FIXME once it gets fixed.

For extra readability, consider removing all abbreviations.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list