[Bug 32986] Add a python example showing how to ensure a channel

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jan 28 13:41:28 CET 2011


https://bugs.freedesktop.org/show_bug.cgi?id=32986

--- Comment #4 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-01-28 04:41:27 PST ---
(In reply to comment #3)
> > +def create_request(action, contact_id):
> 
> Was surprised to see that it didn't returned some kind of Request object, I
> would rename it to create_request_dict() or something similar.

done.

> > +    # FIXME: for some reason TelepathyGLib.USER_ACTION_TIME_CURRENT_TIME is
> 
> I would add a link to the bug to increase the chances that someone will remove
> the FIXME once it gets fixed.

done.

> For extra readability, consider removing all abbreviations.

Good idea; I've done that.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list