[Bug 38249] Add API for the ChannelRequest.DelegateToPreferredHandler hint

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Fri Jul 8 02:00:29 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=38249

--- Comment #12 from Danielle Madeley <danielle.madeley at collabora.co.uk> 2011-07-07 17:00:28 PDT ---
Review of attachment 48843:
 --> (https://bugs.freedesktop.org/review?bug=38249&attachment=48843)

::: telepathy-glib/account-channel-request.c
@@ +1676,3 @@
+ * tp_account_channel_request_create_and_handle_channel_async () or
+ * tp_account_channel_request_ensure_and_observe_channel_async() has been
+ * the org.freedesktop.Telepathy.ChannelRequest.DelegateToPreferredHandler

This is really awkwardly worded, it took me 4 rereadings to work out what you
were saying.

Perhaps simply, "@callback may be called any time after (and only after)
requesting and handling the channel (i.e. you have called create_and_handle or
ensure_and_handle).

N.B. you have written ensure_and_observe, which is wrong.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list