[Bug 38997] Factor out some socket utility functions

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Tue Jul 12 11:01:01 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=38997

--- Comment #5 from Xavier Claessens <xclaesse at gmail.com> 2011-07-12 02:01:01 PDT ---
Shouldn't you protect all gunix* with #ifdef for _tp_create_local_socket()? I
think even the +#include <gio/gunixsocketaddress.h> should be protected because
those headers are not installed on windows'glib. I could be wrong though...

In all those functions you assume out args are not NULL, it's fine since they
are internal APIs, but maybe add a g_assert on top of the methods to make it
explicit?

The rest seems OK.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.



More information about the telepathy-bugs mailing list