[Bug 38997] Factor out some socket utility functions

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38997

--- Comment #6 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-07-12 06:20:00 PDT ---
(In reply to comment #5)
> Shouldn't you protect all gunix* with #ifdef for _tp_create_local_socket()? I
> think even the +#include <gio/gunixsocketaddress.h> should be protected because
> those headers are not installed on windows'glib. I could be wrong though...

You're right. Fixed (amended in 2nd commit and added a new one).

While I was at it, I fixed the stream tube test to pass if UNIX sockets are not
there.

> In all those functions you assume out args are not NULL, it's fine since they
> are internal APIs, but maybe add a g_assert on top of the methods to make it
> explicit?

Good idea; done (amended)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.