[Bug 38986] Merge Call.DRAFT2 into master

bugzilla-daemon at freedesktop.org bugzilla-daemon at freedesktop.org
Thu Jul 14 15:01:37 CEST 2011


https://bugs.freedesktop.org/show_bug.cgi?id=38986

--- Comment #7 from Will Thompson <will.thompson at collabora.co.uk> 2011-07-14 06:01:34 PDT ---
I have fixed some nitpicks on the spec XML in
<http://cgit.collabora.com/git/user/wjt/telepathy-spec-wjt.git/log/?h=call>.
Here are some others:

+    <method name="Reject" tp:name-for-bindings="Reject">
+      <tp:docstring>
+        Reject the proposed update to the remote description
+        FIXME add error codes and strings here
+      </tp:docstring>
+    </method>

Here lies a FIXME.

+    <tp:enum name="Local_Mute_State" type="u">
+      <tp:docstring>
+        The mute state of a channel.
+      </tp:docstring>

This should presumably say “channel, content or stream”. Ditto some of the
other docs here?

+        to <tp:type>Call_State</tp:type>_Initialising, which signifies
+        that the call is waiting for the network to do
+        something (When the CM has information about when the remote contact
is
+        notified about the call (or the network is known not to convey such
+        information) it should also change to
+        <tp:type>Call_State</tp:type>_Ringing. All changes to
+        <tp:member-ref>CallState</tp:member-ref> property are signalled using
+        the <tp:member-ref>CallStateChanged</tp:member-ref> signal.</p>

I think the first " (W" should be ". W"?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.


More information about the telepathy-bugs mailing list