[Bug 38986] Merge Call.DRAFT2 into master

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38986

--- Comment #8 from David Laban <david.laban at collabora.co.uk> 2011-07-14 20:49:19 PDT ---
Your changes all looked good, so I based my revised
http://cgit.collabora.com/git/user/alsuren/telepathy-spec.git/log/?h=call on
it. Hopefully, we can tag-team this until we get it merged?

(note that I'm in theory on holiday on Friday and Monday, but I will probably
be hacking on the road).


> Here lies a FIXME.

Thanks. Fixed.
> 
> +    <tp:enum name="Local_Mute_State" type="u">
> +      <tp:docstring>
> +        The mute state of a channel.
> +      </tp:docstring>
> 
> This should presumably say “channel, content or stream”. Ditto some of the
> other docs here?
> 
Yeah: I re-worked that section

> +        to <tp:type>Call_State</tp:type>_Initialising, which signifies
> +        that the call is waiting for the network to do
> +        something (When the CM has information about when the remote contact
> is
> +        notified about the call (or the network is known not to convey such
> +        information) it should also change to
> +        <tp:type>Call_State</tp:type>_Ringing. All changes to
> +        <tp:member-ref>CallState</tp:member-ref> property are signalled using
> +        the <tp:member-ref>CallStateChanged</tp:member-ref> signal.</p>
> 
> I think the first " (W" should be ". W"?

Correct, and there were other things wrong with that paragraph, so I changed
it.

I also had a strong suspicion that many references to tp:enumvalues were wrong,
so I went on a yak-shave and made it possible to check for them. If you'd
rather I didn't add the extra xml element type (or have better names/semantics)
I'd be happy to re-work those commits and/or delete them and only ship the
fixes for the problems they reveal.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.