[Bug 38801] Missing _async() wrappers for Channel.Group, Connection.ContactList and Connection.ContactGroups interfaces

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38801

--- Comment #16 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-07-15 03:13:05 PDT ---
Review of attachment 49126:
 --> (https://bugs.freedesktop.org/review?bug=38801&attachment=49126)

::: docs/reference/telepathy-glib-sections.txt
@@ +3543,3 @@
 tp_contact_info_list_copy
 tp_contact_info_list_free
+<SUBSECTION contact-list>

You should either add
<INCLUDE>telepathy-glib/connection-contact-list.h</INCLUDE>
or include it in connection.h

::: telepathy-glib/connection-contact-list.c
@@ +49,3 @@
+    g_return_if_fail (TP_IS_CONNECTION (self)); \
+    g_return_if_fail (tp_proxy_has_interface_by_id (self, \
+        TP_IFACE_QUARK_CONNECTION_INTERFACE_CONTACT_LIST)); \

Isn't this too much? That means apps will have to check if the connection does
implement CL before using this function if they don't want to raise a critical.

@@ +72,3 @@
+ * @message: an optional plain-text message from the user, to send to those
+ *  @contacts with the subscription request. The
+ *  #TpConnection:request-uses-message property indicates whether this message

This property doesn't exist yet.

::: telepathy-glib/connection-contact-list.h
@@ +1,2 @@
+/*
+ * connection.h - proxy for a Telepathy connection

bouh

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.