[Bug 38801] Missing _async() wrappers for Channel.Group, Connection.ContactList and Connection.ContactGroups interfaces

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38801

--- Comment #17 from Guillaume Desmottes <guillaume.desmottes at collabora.co.uk> 2011-07-15 03:18:54 PDT ---
Review of attachment 49127:
 --> (https://bugs.freedesktop.org/review?bug=38801&attachment=49127)

::: telepathy-glib/connection-contact-list.c
@@ +313,3 @@
+    g_return_if_fail (TP_IS_CONNECTION (self)); \
+    g_return_if_fail (tp_proxy_has_interface_by_id (self, \
+    GSimpleAsyncResult *result; \

Same comment as above.

@@ +315,3 @@
+        TP_IFACE_QUARK_CONNECTION_INTERFACE_CONTACT_GROUPS)); \
+    g_return_if_fail (_tp_contacts_to_handles (self, n_contacts, contacts, \
+    GArray *handles; \

add g_return_if_fail (group != NULL);

@@ +496,3 @@
+    g_return_if_fail (tp_proxy_has_interface_by_id (self,
+        TP_IFACE_QUARK_CONNECTION_INTERFACE_CONTACT_GROUPS));
+}

check group != NULL

@@ +555,3 @@
+    g_return_if_fail (tp_proxy_has_interface_by_id (self,
+        TP_IFACE_QUARK_CONNECTION_INTERFACE_CONTACT_GROUPS));
+ * @callback: a callback to call when the operation finishes

Same here, for boths.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.