[Bug 39334] New: Misreports RequestConnection failing as NetworkError

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=39334

           Summary: Misreports RequestConnection failing as NetworkError
           Product: Telepathy
           Version: git master
          Platform: Other
        OS/Version: All
            Status: NEW
          Severity: normal
          Priority: medium
         Component: mission-control
        AssignedTo: telepathy-bugs at lists.freedesktop.org
        ReportedBy: will.thompson at collabora.co.uk
         QAContact: telepathy-bugs at lists.freedesktop.org


If RequestConnection fails, MC disregards the specific error, and just claims a
network error occurred:

    if (tperror)
    {
        g_warning ("%s: RequestConnection failed: %s",
                   G_STRFUNC, tperror->message);

        g_signal_emit (connection, signals[CONNECTION_STATUS_CHANGED], 0,
            TP_CONNECTION_STATUS_DISCONNECTED,
            TP_CONNECTION_STATUS_REASON_NETWORK_ERROR, NULL);
        return;
    }

This is not very helpful. My reading of the spec is that accounts with invalid
parameters should be marked with Valid: False. I don't think that would be
helpful either. ;)

We should probably use the DBus error name returned by RequestConnection—in
this case, InvalidArgument. (I've checked Empathy and it currently doesn't do
anything useful with InvalidArgument, but that could be changed.) I can't
really see any better Connection_Status_Reason than None_Specified. :(

(Obviously, this is a sign that I should add validation to the new “Username”
field in Empathy for IRC accounts.)

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.