[Bug 38142] proxy factories

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38142

--- Comment #59 from Will Thompson <will.thompson at collabora.co.uk> 2011-07-18 10:26:52 PDT ---
(In reply to comment #55)
> Thanks for that contribution :)
> 
> (In reply to comment #54)
> > +++ b/telepathy-glib/automatic-client-factory-internal.h
> > @@ -0,0 +1,45 @@
> > +/*
> > + * Automatic client factory internal
> > 
> > Gee, what a helpful description of the file. ;)
> 
> suggestion?

“Internal constructors for TpChannel subclasses” maybe? I've changed it to
this. I've changed various others too.

My point is really: why bother adding this comment if it's just the filename
with s/-/ /? Ditto @short_description: describing TpSimpleClientFactory as
“simple client factory” doesn't add anything. What's a client, what's a factory
and how is this one simple? I replaced this with “a factory for #TpContact<!--
-->s and plain subclasses of #TpProxy”.

+      /* A common usage is request_and_handle, in that case EnsureChannel
+       * returns only the object-path of the ChannelRequest but not
properties.
+       * The TpChannelRequest will be created with no properties, then when
+       * handling we get the properties and we reuse the same TpChannelRequest
+       * object, and we can give it the immutable-properties. */

Eh? This doesn't sound right. The client library should know the immutable
properties of the ChannelRequest that EnsureChannel() returns because it
specified them when it called EnsureChannel().

There are a pile more patches on my branch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.