[Bug 38986] Merge Call.DRAFT2 into master

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38986

--- Comment #10 from David Laban <david.laban at collabora.co.uk> 2011-07-19 07:30:37 PDT ---

> > > Here lies a FIXME.
> > 
> > Thanks. Fixed.
> 
> +      <arg name="Reason" type="(uuss)" tp:type="Call_State_Reason"
> +        direction="out">
> +        <tp:docstring>
> +          A structured reason for the rejection.
> +        </tp:docstring>
> +      </arg>
> 
> The actor is always going to be us, and the reason will always be Media_Error
> presumably? I'm just wondering whether this should just be a D-Bus error plus
> message string—if this is a case of “the whole Call API uses this struct
> consistently” then no problem.

It is indeed a consistency thing.


> > I also had a strong suspicion that many references to tp:enumvalues were wrong,
> > so I went on a yak-shave and made it possible to check for them. If you'd
> > rather I didn't add the extra xml element type (or have better names/semantics)
> > I'd be happy to re-work those commits and/or delete them and only ship the
> > fixes for the problems they reveal.
> 
> I really like the revised style where the contents of <tp:value-ref> is always
> what's displayed in the document, and fully endorse your implementation. I've
> pushed a couple of improvements to the text interface's markup (since the sed
> touched that, and I noticed it would look wrong).

I think your changes look good. Do you want to ship it, or should I do so
tomorrow?

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.