[Bug 38986] Merge Call.DRAFT2 into master

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=38986

--- Comment #9 from Will Thompson <will.thompson at collabora.co.uk> 2011-07-15 07:31:21 PDT ---
(In reply to comment #8)
> Your changes all looked good, so I based my revised
> http://cgit.collabora.com/git/user/alsuren/telepathy-spec.git/log/?h=call on
> it. Hopefully, we can tag-team this until we get it merged?

Sounds good. I pushed a couple more fixes.

> > Here lies a FIXME.
> 
> Thanks. Fixed.

+      <arg name="Reason" type="(uuss)" tp:type="Call_State_Reason"
+        direction="out">
+        <tp:docstring>
+          A structured reason for the rejection.
+        </tp:docstring>
+      </arg>

The actor is always going to be us, and the reason will always be Media_Error
presumably? I'm just wondering whether this should just be a D-Bus error plus
message string—if this is a case of “the whole Call API uses this struct
consistently” then no problem.

Heh, I didn't notice the over-zealous sedding. Whoops, sorry.

> I also had a strong suspicion that many references to tp:enumvalues were wrong,
> so I went on a yak-shave and made it possible to check for them. If you'd
> rather I didn't add the extra xml element type (or have better names/semantics)
> I'd be happy to re-work those commits and/or delete them and only ship the
> fixes for the problems they reveal.

I really like the revised style where the contents of <tp:value-ref> is always
what's displayed in the document, and fully endorse your implementation. I've
pushed a couple of improvements to the text interface's markup (since the sed
touched that, and I noticed it would look wrong).

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.