[Bug 37034] Telepathy-Qt4 doesn't set the URI property for file transfers.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37034

--- Comment #15 from Olli Salli <ollisal at gmail.com> 2011-06-03 01:31:04 PDT ---
> A problem I noticed is that the channel is requested even if the
> FileTransferChannelCreationProperties is not valid (not only by using the path
> constructor, but also using the default constructor). Maybe an error should be
> returned before requesting the channel, but the method returns a
> PendingChannelRequest* and therefore it is not possible to return a
> PendingFailure*, maybe a PendingChannelRequestFailure class should be
> implemented? Or should it be left as it is now and just start the request
> waiting for the failure from CM?

No, we don't need a separate subclass for that. Just add a new ctor to the
current one which takes the error name and message, and immediately calls
setFinishedWithError without doing anything else. This is in fact how it's done
with e.g. PendingHandles.

Subclassing wouldn't work because the current PCR ctor does a lot of things to
start the channel request - so as any subclass would have to invoke it, it'd do
those things as well.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.