[Bug 37034] Telepathy-Qt4 doesn't set the URI property for file transfers.

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=37034

Olli Salli <ollisal at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Status Whiteboard|review-                     |review+ after a small
                   |                            |change

--- Comment #16 from Olli Salli <ollisal at gmail.com> 2011-06-03 01:47:15 PDT ---
Oh, you went the distance of adding a separate testcase! I'd say split the FTC
test to 4 individual slots/testcases (corresponding to each of your current
basic blocks in the one big slot). More readable, and gives more accurate
output in the case of a test failure. Otherwise the test looks nice!

Bonus points for adding the tests for the Account request method itself. You
can improve it further after the setFinishedWithError ctor with an invalid
creation properties instance. The PCR should fail with INVALID_ARGUMENT in that
case.

Please ping me after doing the adjustments from this and the previous comment,
and I'll merge.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.