[Bug 34027] Salut should have a plugin API

[bugzilla-daemon at freedesktop.org]

https://bugs.freedesktop.org/show_bug.cgi?id=34027

Jonny Lamb <jonny.lamb at collabora.co.uk> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                URL|http://git.collabora.co.uk/ |http://cgit.freedesktop.org
                   |?p=user/jonny/telepathy-sal |/~jonny/telepathy-salut/log
                   |ut.git;a=shortlog;h=refs/he |?h=plugin
                   |ads/plugin                  |

--- Comment #3 from Jonny Lamb <jonny.lamb at collabora.co.uk> 2011-03-02 08:54:02 PST ---
(In reply to comment #1)
> This can be G_DEFINE_INTERFACE() since 2.24 I think.

Done.

(In reply to comment #2)
> +  g_ptr_array_foreach (tmp, add_to_array, managers);
> +  g_ptr_array_free (tmp, FALSE);
> 
> +      g_ptr_array_foreach (managers, copy_to_other_array, out);
> +      g_ptr_array_free (managers, TRUE);
> 
> Same review comment as for the corresponding code in Gabble.

Actually having some tp_g_ptr_array_extend or something wouldn't help because
the typo is outside said common code, unless it was "take the pointer array and
free it?". Anyway, I fixed the wrong one.

> Really, you should say that the caller takes ownership of the array and of the
> references to channel managers within it, and maybe refer to
> TpBaseConnectionCreateChannelManagersImpl which has the same semantics?

Okay, done.

> This looks wrong: I think you've got the order of the two arguments wrong?

Good catch, fixed.

All the above fixed and pushed to my branch.

-- 
Configure bugmail: https://bugs.freedesktop.org/userprefs.cgi?tab=email
------- You are receiving this mail because: -------
You are the QA contact for the bug.
You are the assignee for the bug.